adapt to new colorbar behavior in mpl 3.0. fixes #2099 #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
reviewed
Nov 26, 2018
cphyc
approved these changes
Nov 26, 2018
matthewturk
approved these changes
Nov 26, 2018
jzuhone
approved these changes
Nov 26, 2018
|
Ugh wish I'd looked closer at the test failures when I updated the tests to use matplotlib 3, would have caught this then. Oh well.... Will push new test answers shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matplotlib 3.0 includes a number of improvements to colorbars, one of which makes a hack in yt's handling of colorbars unnecessary, leading to the weird behavior in #2099. The fix is to guard the hack behind a matplotlib version check.